Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregator stress test #1679

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented May 14, 2024

Content

This PR includes a fix for the aggregator stress test.
Due to updates on the aggregator node, the bootstrap of the aggregator stress test was no longer working (e.g. here).
To succeed, an additional step was required, involving a restart of the aggregator and to move one epoch forward before the signing registration.

The results of the Github workflow that the aggregator stress test with 500 signers and 500 clients can be found here.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1676

Copy link

github-actions bot commented May 14, 2024

Test Results

    3 files  ±0     43 suites  ±0   8m 34s ⏱️ -4s
  959 tests ±0    959 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 053 runs  ±0  1 053 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4f3fc48. ± Comparison against base commit 24f749b.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview May 14, 2024 16:57 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 14, 2024 16:57 — with GitHub Actions Inactive
@dlachaume dlachaume self-assigned this May 14, 2024
@dlachaume dlachaume marked this pull request as ready for review May 14, 2024 17:41
@dlachaume dlachaume requested review from jpraynaud, Alenar and sfauvel May 14, 2024 17:41
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from 68b93f4 to d332309 Compare May 15, 2024 14:46
@dlachaume dlachaume temporarily deployed to testing-preview May 15, 2024 14:53 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 15, 2024 14:53 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from d332309 to a5c1e5c Compare May 15, 2024 15:00
@dlachaume dlachaume temporarily deployed to testing-preview May 15, 2024 15:07 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 15, 2024 15:07 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from a5c1e5c to 1ae3bf1 Compare May 15, 2024 15:17
@dlachaume dlachaume temporarily deployed to testing-preview May 15, 2024 15:24 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 15, 2024 15:24 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from 1ae3bf1 to 7d70136 Compare May 15, 2024 16:30
@dlachaume dlachaume temporarily deployed to testing-preview May 15, 2024 16:39 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 15, 2024 16:39 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-preview May 15, 2024 17:31 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 15, 2024 17:31 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from 208dd92 to 7e001c6 Compare May 16, 2024 07:38
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2024 07:44 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 16, 2024 07:44 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from 7e001c6 to f392544 Compare May 16, 2024 07:58
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2024 08:04 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 16, 2024 08:04 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from f392544 to 1a341bb Compare May 16, 2024 08:18
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2024 08:24 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 16, 2024 08:24 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1676/fix-aggregator-stress-test branch from 1a341bb to 4f3fc48 Compare May 16, 2024 08:31
@dlachaume dlachaume temporarily deployed to testing-preview May 16, 2024 08:38 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet May 16, 2024 08:38 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit cab7cb1 into main May 16, 2024
42 of 43 checks passed
@dlachaume dlachaume deleted the dlachaume/1676/fix-aggregator-stress-test branch May 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregator stress test crashes during signer registration
3 participants