-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregator stress test #1679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
temporarily deployed
to
testing-sanchonet
May 14, 2024 16:57 — with
GitHub Actions
Inactive
jpraynaud
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
mithril-test-lab/mithril-end-to-end/src/stress_test/aggregator_helpers.rs
Outdated
Show resolved
Hide resolved
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 15, 2024 14:46
68b93f4
to
d332309
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 15, 2024 14:53 — with
GitHub Actions
Inactive
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 15, 2024 15:00
d332309
to
a5c1e5c
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 15, 2024 15:07 — with
GitHub Actions
Inactive
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 15, 2024 15:17
a5c1e5c
to
1ae3bf1
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 15, 2024 15:24 — with
GitHub Actions
Inactive
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 15, 2024 16:30
1ae3bf1
to
7d70136
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 15, 2024 16:39 — with
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
May 15, 2024 17:31 — with
GitHub Actions
Inactive
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 16, 2024 07:38
208dd92
to
7e001c6
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 16, 2024 07:44 — with
GitHub Actions
Inactive
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 16, 2024 07:58
7e001c6
to
f392544
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 16, 2024 08:04 — with
GitHub Actions
Inactive
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 16, 2024 08:18
f392544
to
1a341bb
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 16, 2024 08:24 — with
GitHub Actions
Inactive
dlachaume
force-pushed
the
dlachaume/1676/fix-aggregator-stress-test
branch
from
May 16, 2024 08:31
1a341bb
to
4f3fc48
Compare
dlachaume
temporarily deployed
to
testing-sanchonet
May 16, 2024 08:38 — with
GitHub Actions
Inactive
Alenar
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix for the aggregator stress test.
Due to updates on the aggregator node, the bootstrap of the aggregator stress test was no longer working (e.g. here).
To succeed, an additional step was required, involving a restart of the aggregator and to move one epoch forward before the signing registration.
The results of the Github workflow that the aggregator stress test with 500 signers and 500 clients can be found here.
Pre-submit checklist
Issue(s)
Closes #1676