Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-7654 Re-benchmarked Runtime resources and syncing. #718

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Sep 24, 2023

Updated Runtime's resource page, based on benchmarking v0.0.5 for sync times and resource usage.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@bwbush bwbush self-assigned this Sep 24, 2023
@bwbush bwbush added documentation Improvements or additions to documentation No Changelog Required Turns of the check-changelog check labels Sep 24, 2023
| `marlowe-sync` | 50 MB | 25 % |
| `marlowe-contract` | 25 MB | 5 % |
| `marlowe-contract` | 25 MB | 10 % |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this should be higher; we should benchmark uploading large contracts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite possible, since our scaling tests do not hit marlowe-contract very hard.

@bwbush bwbush enabled auto-merge September 27, 2023 12:27
@bwbush bwbush merged commit cf30c3a into main Sep 27, 2023
5 checks passed
@bwbush bwbush deleted the PLT-7654 branch September 27, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation No Changelog Required Turns of the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants