Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-7328 - upgrade cardano #709

Merged
merged 24 commits into from
Sep 20, 2023
Merged

PLT-7328 - upgrade cardano #709

merged 24 commits into from
Sep 20, 2023

Conversation

jhbertra
Copy link
Contributor

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@jhbertra jhbertra force-pushed the plt-7331-upgrade-cardano branch from 787872b to 73c3a86 Compare September 10, 2023 20:31
Base automatically changed from plt-7884-x-plutus-apps to main September 11, 2023 14:17
@jhbertra jhbertra force-pushed the plt-7331-upgrade-cardano branch 3 times, most recently from 3d746ad to cf912c8 Compare September 14, 2023 20:26
@jhbertra jhbertra changed the base branch from main to plt-7541-separate-plutus September 14, 2023 20:27
@jhbertra jhbertra force-pushed the plt-7331-upgrade-cardano branch 2 times, most recently from 8221b0a to 64aa196 Compare September 15, 2023 15:23
Base automatically changed from plt-7541-separate-plutus to main September 15, 2023 17:12
@jhbertra jhbertra force-pushed the plt-7331-upgrade-cardano branch 2 times, most recently from a7f2ec7 to 306735b Compare September 18, 2023 17:14
@jhbertra jhbertra force-pushed the plt-7331-upgrade-cardano branch from 306735b to 30996b1 Compare September 19, 2023 14:01
@jhbertra jhbertra force-pushed the plt-7331-upgrade-cardano branch from a8edb26 to f930cc4 Compare September 19, 2023 16:58
@jhbertra jhbertra marked this pull request as ready for review September 19, 2023 17:03
@jhbertra jhbertra requested review from bwbush and paluh September 19, 2023 17:03
bwbush
bwbush reviewed Sep 20, 2023
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
bwbush
bwbush approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@bwbush bwbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks so much. Great that the lint and some spelling mistakes were fixed, too.

I left a few minor comments and questions.

@jhbertra jhbertra enabled auto-merge September 20, 2023 17:31
@jhbertra jhbertra merged commit b39fe3c into main Sep 20, 2023
@jhbertra jhbertra deleted the plt-7331-upgrade-cardano branch September 20, 2023 18:04
@palas palas changed the title Plt 7331 upgrade cardano PLT-7328 - upgrade cardano Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbush bwbush bwbush approved these changes

@paluh paluh Awaiting requested review from paluh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhbertra @bwbush