Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fragments-endpoints): Add /fragments and /fragments/statuses compatibility endpoints #93

Merged
merged 11 commits into from
Nov 28, 2023
Merged

feat(fragments-endpoints): Add /fragments and /fragments/statuses compatibility endpoints #93

merged 11 commits into from
Nov 28, 2023

Conversation

FelipeRosa
Copy link

@FelipeRosa FelipeRosa commented Oct 27, 2023 •
edited
Loading

Description

This PR adds the /fragments and /fragments/statuses compatibility endpoints.

  • Endpoint code
  • Documentation

Related Issue(s)

Closes #55
Closes #56

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@FelipeRosa FelipeRosa self-assigned this Oct 27, 2023
@FelipeRosa FelipeRosa added the draft Draft label Oct 27, 2023
@FelipeRosa FelipeRosa force-pushed the feature/fragments-endpoints branch 2 times, most recently from c6eda2f to 7859467 Compare November 1, 2023 19:36
@FelipeRosa FelipeRosa force-pushed the feature/fragments-endpoints branch 4 times, most recently from 9d28978 to dde01ed Compare November 14, 2023 12:57
@FelipeRosa FelipeRosa marked this pull request as ready for review November 14, 2023 12:57
@FelipeRosa FelipeRosa removed the draft Draft label Nov 14, 2023
@FelipeRosa FelipeRosa force-pushed the feature/fragments-endpoints branch from dde01ed to b7c84c5 Compare November 14, 2023 17:11
@FelipeRosa FelipeRosa force-pushed the feature/fragments-endpoints branch from a564df5 to 34843b1 Compare November 15, 2023 13:47
@minikin minikin enabled auto-merge (squash) November 15, 2023 14:04
Mr-Leshiy
Mr-Leshiy previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelipeRosa FelipeRosa requested a review from Mr-Leshiy November 20, 2023 18:46
@minikin minikin added the review me PR is ready for review label Nov 21, 2023
@FelipeRosa FelipeRosa requested a review from stevenj November 21, 2023 13:52
stevenj
stevenj approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj dismissed saibatizoku’s stale review November 28, 2023 04:14

Resolved already

@minikin minikin merged commit 712dbf4 into main Nov 28, 2023
21 checks passed
@minikin minikin deleted the feature/fragments-endpoints branch November 28, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj stevenj approved these changes

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

Assignees

@FelipeRosa FelipeRosa

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
5 participants
@FelipeRosa @saibatizoku @stevenj @Mr-Leshiy @minikin