Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup targets #185

Merged
merged 7 commits into from
Jan 9, 2024
Merged

fix: cleanup targets #185

merged 7 commits into from
Jan 9, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Dec 12, 2023 •
edited
Loading

Description

Cleanup targets

Related Issue(s)

Closes #184

Description of Changes

  • Remove unnecessary targets
  • Rename targets
  • New Cat-ci workflow should work as expected

Breaking Changes

Screenshots

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn self-assigned this Dec 12, 2023
@bkioshn bkioshn added the enhancement New feature or request label Dec 12, 2023
@Mr-Leshiy Mr-Leshiy added the draft Draft label Dec 12, 2023
@bkioshn bkioshn removed the draft Draft label Jan 9, 2024
stevenj
stevenj approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 820ea53 into main Jan 9, 2024
21 checks passed
@stevenj stevenj deleted the fix/cleanup-targets branch January 9, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

Assignees

@bkioshn bkioshn

Labels
enhancement New feature or request
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Cleanup targets and test the new target scanner
3 participants
@bkioshn @stevenj @Mr-Leshiy