Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flutter adr, update catalyst_voices_assets #164

Merged
merged 4 commits into from
Nov 30, 2023
Merged

feat: add flutter adr, update catalyst_voices_assets #164

merged 4 commits into from
Nov 30, 2023

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Nov 29, 2023

Description

  • Add ADR on why we decided to use Flutter
  • Add the internal_resources folder to catalyst_voices_assets

Related Issue(s)

Closes #161

Breaking Changes

None

Screenshots

Not applicable

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@minikin minikin marked this pull request as ready for review November 29, 2023 12:41
@minikin minikin self-assigned this Nov 29, 2023
@minikin minikin requested a review from stevenj November 29, 2023 12:41
@minikin minikin enabled auto-merge (squash) November 29, 2023 12:42
@minikin minikin added the review me PR is ready for review label Nov 29, 2023
Mr-Leshiy
Mr-Leshiy approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 8926089 into main Nov 30, 2023
21 checks passed
@minikin minikin deleted the feature/add-adr-flutter branch November 30, 2023 09:16
stevenj
stevenj approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj stevenj approved these changes

Assignees

@minikin minikin

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Architecture Decisions: Why do we use Flutter?
3 participants
@minikin @stevenj @Mr-Leshiy