Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(catalyst-gateway): Remove axum legacy service implementation #162

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Nov 28, 2023

Description

  • Removed Axum based legacy service endpoints implementation

Related Issue(s)

Closes #140

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy changed the title refact(catalyst-gateway): Remove axum legacy service implementation refactor(catalyst-gateway): Remove axum legacy service implementation Nov 28, 2023
@Mr-Leshiy Mr-Leshiy force-pushed the refact/remove-legacy-service-endpoints branch from 3399e16 to 34e0899 Compare November 28, 2023 19:30
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Nov 29, 2023
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj enabled auto-merge (squash) November 30, 2023 09:19
@stevenj stevenj merged commit 977194b into main Nov 30, 2023
11 checks passed
@stevenj stevenj deleted the refact/remove-legacy-service-endpoints branch November 30, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Remove legacy service code from catalyst gateway
2 participants