modifying wash_out to work with EPIC EHR for health data #232
Conversation
…ike the other integrations for epic
| @@ -1,11 +1,62 @@ | |||
| # <s:Envelope | |||
There was a problem hiding this comment.
I don't think you should leave comments like this
| @@ -1,3 +1,3 @@ | |||
| module WashOut | |||
| VERSION = "0.9.2" | |||
| VERSION = "1.1.1" | |||
There was a problem hiding this comment.
I moved to 1.0.0 first but then made a few more changes hence internally changed that version to 1.1.1. But can pick a different version based your convention for major minor.
| @@ -19,7 +29,7 @@ xml.definitions 'xmlns' => 'http://schemas.xmlsoap.org/wsdl/', | |||
| end | |||
| end | |||
|
|
|||
| xml.portType :name => "#{@name}_port" do | |||
| xml.portType :name => "IWebPortal", :type => "tns:IWebPortal" do | |||
|
@betarelease this is what I hate about the "standards" of SOAP, there are too much flavors, I had problems to make my WSDL Apache CXF valid and TIBCO compatible, in the end I used a forked version of wash_out because it is just too specific to be really used in the master branch, I suggest you leave this for others but in a different branch. |
|
haha @jdsampayo We all hate these SOAPy things. I did make these changes and forked it for my use. I wanted to ensure we have it upstream so that others who are trying to use this arcane technology benefit. Should I push this request into a different branch or can you create a branch 'EpicEHRWsdl' and push these changes there. I have a copy on my fork for these changes anyway. |
|
@betarelease I'm just a mortal, we should wait for @inossidabile guidance |
|
Hey. So did you just modify gem in place effectively making it incompatible with other stuff right? Just a sanity check. |
Thanks for building this. I was able to build a healthcare integration thanks to you.
I had to make some modifications to the base wash_out gem to support this EPIC functionality with WSDLs. You can accept if you think they apply to the rest of the world or publish a version that applies to EPIC.