Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pool arm no arm #301

Closed
wants to merge 1 commit into from
Closed

fix: update pool arm no arm #301

wants to merge 1 commit into from

Conversation

cowan-macady
Copy link
Contributor

implement ENG-5055

@cowan-macady cowan-macady requested a review from a team as a code owner December 3, 2024 10:21
Copy link

deepsource-io bot commented Dec 3, 2024

Here's the code health analysis summary for commits 3341213..5cfe9dd. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cowan-macady cowan-macady requested review from marvinkite and removed request for jakubtomany December 3, 2024 10:24
@cowan-macady cowan-macady changed the title feat: update after EM modif on upd feat: update pool arm no arm Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (3341213) to head (5cfe9dd).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
grpc/uint32_noarm.go 40.00% 4 Missing and 2 partials ⚠️
grpc/pool.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   72.30%   72.24%   -0.06%     
==========================================
  Files          39       40       +1     
  Lines        2011     2018       +7     
==========================================
+ Hits         1454     1458       +4     
- Misses        493      495       +2     
- Partials       64       65       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

implement ENG-5055
@cowan-macady cowan-macady changed the title feat: update pool arm no arm fix: update pool arm no arm Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant