Data refs tests

[cowan-macady]

• add tests for kbac external property
• add values in constants (automation comes soon)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.30%. Comparing base (cb7ea0a) to head (6d1b476).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files          39       39           
  Lines        2011     2011           
=======================================
  Hits         1454     1454           
  Misses        493      493           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deepsource-io]

Here's the code health analysis summary for commits cb7ea0a..6d1b476. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Go	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[jakubtomany]

Please, use DescribeTable+Entry to make the code shorter, it'll be easier to review then...

[jakubtomany]

you could rewrite this using some helper function like e.g. (didn't try if it actually works):

func matchDecisions(resources []*authorizationpb.IsAuthorizedRequest_Resource, allow bool) types.GomegaMatcher {
    typeToResourceKeys := map[any]Keys
    for _, resource := range resources {
        resourceKeys, ok := typeToResourceKeys[resource.Type]
        if !ok {
            resourceKeys = Keys{}
            typeToResourceKeys[resource.Type] = resourceKeys
        }
        actionKeys := Keys{}
        for _, action := range resource.Actions {
            actionsKeys[action] = PointTo(MatchFields(IgnoreExtras, Fields{
                "Allow": Equal(allow),
            }))
        }
        resourceKeys[resource.ExternalId] = PointTo(MatchFields(IgnoreExtras, Fields{
            "Actions": MatchAllKeys(actionKeys),
        }))
    }
    decisionKeys := Keys{}
    for resourceType, resourceKeys := range typeToResources {
        decisionKeys[resourceType] = PointTo(MatchFields(IgnoreExtras, Fields{
            "Resources": MatchAllKeys(resourceKeys),
        }))
    }
    return MatchAllKeys(decisionKeys)
}

But I'll let you decide if it is the way to write tests - one could argue it is too complex for being a test code :)

[jakubtomany]

And now I see this "clever" solution may be even more code than your solution :)

[jakubtomany]

Please ignore this suggestion above and rather split these test cases, so there is no need for if numberResources == 2 condition...

[cowan-macady]

updated

[jakubtomany]

Code LGTM, I'll let you decide whether you use the suggestion I've written above or not.