Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove read report function and add tests #283

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

cowan-macady
Copy link
Contributor

implement ENG-4927

  • remove ReadEntityMatchingReportRequest
  • add EM integration tests
  • create new appSpace

@cowan-macady cowan-macady requested a review from a team as a code owner October 17, 2024 14:32
@cowan-macady cowan-macady requested a review from arxeiss October 17, 2024 14:32
@cowan-macady
Copy link
Contributor Author

deletion of EM config node can be blocked. Fix will be added in the BE

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.52%. Comparing base (c9d1b8d) to head (6de3967).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   72.53%   72.52%   -0.02%     
==========================================
  Files          39       39              
  Lines        1653     1645       -8     
==========================================
- Hits         1199     1193       -6     
+ Misses        389      388       -1     
+ Partials       65       64       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cowan-macady cowan-macady removed request for a team and arxeiss October 17, 2024 14:34
Copy link

deepsource-io bot commented Oct 17, 2024

Here's the code health analysis summary for commits c9d1b8d..6de3967. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cowan-macady cowan-macady requested review from a team and jakubtomany and removed request for jakubtomany October 17, 2024 14:49
@cowan-macady cowan-macady merged commit f120e3a into master Oct 18, 2024
11 checks passed
@cowan-macady cowan-macady deleted the entity-tests branch October 18, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants