Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test config #279

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Test config #279

merged 1 commit into from
Oct 8, 2024

Conversation

cowan-macady
Copy link
Contributor

  • add tests for resolver config node
  • update config files to create tests

@cowan-macady cowan-macady requested a review from a team as a code owner October 7, 2024 07:28
@cowan-macady cowan-macady requested a review from arxeiss October 7, 2024 07:28
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (9769370) to head (0e16fb2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
grpc/pool.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   72.53%   72.59%   +0.06%     
==========================================
  Files          38       38              
  Lines        1642     1642              
==========================================
+ Hits         1191     1192       +1     
+ Misses        390      387       -3     
- Partials       61       63       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

deepsource-io bot commented Oct 7, 2024

Here's the code health analysis summary for commits 9769370..0e16fb2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cowan-macady cowan-macady force-pushed the test-config branch 3 times, most recently from fd10b19 to b9b5665 Compare October 7, 2024 10:58
Copy link
Contributor

@Septimus4 Septimus4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests, I see you removed the entity matching hack 👍

@cowan-macady cowan-macady merged commit 15be803 into master Oct 8, 2024
11 checks passed
@cowan-macady cowan-macady deleted the test-config branch October 8, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants