Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add bq audit log checks to integration tests #205

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

kilimandzsaro
Copy link
Contributor

Checklist

  • make test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected core subsystem(s)

Description of change

ENG-2295: Adding audit log checks to the authz integration tests using BigQuery

@kilimandzsaro kilimandzsaro requested a review from a team as a code owner February 23, 2024 14:56
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.84%. Comparing base (61d8aa3) to head (b189703).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   69.84%   69.84%           
=======================================
  Files          39       39           
  Lines        1897     1897           
=======================================
  Hits         1325     1325           
  Misses        519      519           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kilimandzsaro kilimandzsaro force-pushed the ENG-2295-audit-logs branch 4 times, most recently from 907379e to 2b8dee6 Compare February 26, 2024 12:56
helpers/google_helpers.go Outdated Show resolved Hide resolved
helpers/google_helpers.go Outdated Show resolved Hide resolved
@kilimandzsaro kilimandzsaro force-pushed the ENG-2295-audit-logs branch 3 times, most recently from 5fa428e to 87cc8a5 Compare February 26, 2024 15:13
- ENG-2295 - add audit log checks to the authz integration tests
- Add tester service account to pr workflow for integration tests
@kilimandzsaro kilimandzsaro merged commit ac55bb1 into master Feb 26, 2024
10 checks passed
@kilimandzsaro kilimandzsaro deleted the ENG-2295-audit-logs branch February 26, 2024 16:29
@kilimandzsaro kilimandzsaro restored the ENG-2295-audit-logs branch February 26, 2024 16:29
@kilimandzsaro kilimandzsaro deleted the ENG-2295-audit-logs branch February 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants