feat: implement knowledge v1beta2 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 72.01% 70.02% -2.00%
==========================================
Files 39 39
Lines 2326 2345 +19
==========================================
- Hits 1675 1642 -33
- Misses 596 650 +54
+ Partials 55 53 -2 ☔ View full report in Codecov by Sentry. |
maaland
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Mostly good, just some comments.
I see you're replacing the old version with the new version. Can you first check with @yetizer / @bakkelim that that's okay for them? It might cause issues if they need a fix to something that comes in a later SDK version, but can't update yet because they're not ready to move to IKG API v2
cowan-macady
force-pushed
the
ikg-api-v2
branch
from
da4ed90 to
7683bdc
Compare
cowan-macady
requested review from
maaland,
a team and
arxeiss
and removed request for
arxeiss
maaland
requested changes
Jan 30, 2024
cowan-macady
force-pushed
the
ikg-api-v2
branch
3 times, most recently
from
4f8a046 to
f1acfc8
Compare
|
To be continued with modifications from objects v2 in new PR |
maaland
requested changes
Feb 7, 2024
cowan-macady
force-pushed
the
ikg-api-v2
branch
from
f1acfc8 to
a5bf26e
Compare
maaland
approved these changes
Feb 7, 2024
BREAKING CHANGE: ENG-2778
cowan-macady
force-pushed
the
ikg-api-v2
branch
from
a5bf26e to
a526bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: ENG-2778