Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade everything #154

Merged
merged 1 commit into from
Oct 3, 2023
Merged

chore(deps): upgrade everything #154

merged 1 commit into from
Oct 3, 2023

Conversation

arxeiss
Copy link
Contributor

@arxeiss arxeiss commented Sep 27, 2023

Checklist

  • make test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected core subsystem(s)

Description of change

@arxeiss arxeiss requested a review from a team as a code owner September 27, 2023 09:37
@arxeiss arxeiss requested a review from bakkelim September 27, 2023 09:37
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #154 (ffb33f3) into master (7c79ad9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   62.25%   62.25%           
=======================================
  Files          44       44           
  Lines        2925     2925           
=======================================
  Hits         1821     1821           
  Misses       1033     1033           
  Partials       71       71           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hooks:
- id: markdownlint
exclude: ^(CHANGELOG|responsible_disclosure).md$
# No one is fixing it anyway
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove it?

Copy link
Contributor

@bakkelim bakkelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes in proto gen files? Just forgotten to run the cmd in other PRs?

@arxeiss
Copy link
Contributor Author

arxeiss commented Oct 3, 2023

Why are there changes in proto gen files? Just forgotten to run the cmd in other PRs?
Not sure which cmd you are talking about, but updating deps will update also proto definitions from Buf.build

@arxeiss arxeiss merged commit f87ccc9 into master Oct 3, 2023
@arxeiss arxeiss deleted the upgrade_deps branch October 3, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants