-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Stokes tests to 3d #32
Conversation
Note to self: these currently run, but don't converge :( |
Thanks for working on this! It might be useful to coordinate with @isuruf, who is working on improved support for Stokes from the expansion end. |
Sure. Hopefully they don't intersect too much, since this doesn't touch any of the stuff in |
I played with this a little more and the 2D case looks believable. The errors it gives are
In 3D, something is weird and it doesn't quite seem to converge properly. The density looks a bit piecewise too. Is that just because it's just not refined enough?
|
I agree that the density looks suspicious. Have you tried generously dousing the problem in quadrature resolution? |
58fd1a3
to
f010200
Compare
Found some time to play with this a bit more and checked just oversampling more. The tables are for x4, x6, x8 oversampling.
Looking at the density in the x8 case, it looks a lot nicer than the one for the x4 case from before. These errors and convergence still looks very fishy to me. It has a 3rd order QBX and 3rd order discretization and the quadrature is 12, 18, 24, so I'm not sure where the numbers above are coming from. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I agree that the convergence data is a bit strange. My main two concerns:
- It looks like at least the x4 and x6 cases bottom out in terms of convergence. I'm guessing that's quadrature error.
- I wonder what drives this hunger for source resolution. I'm not sure I have a conjecture, but I sure would like to see a QBX integrand evaluated on the mesh...
Nonetheless, I think this is better off merged than not, especially given that
- the x8 data look "clean enough", and
- the tests aren't close to the "leader board" of slow tests.
What do you think?
Co-authored-by: Andreas Klöckner <[email protected]>
Co-authored-by: Andreas Klöckner <[email protected]>
541ed26
to
302a2c0
Compare
I agree that it's better to merge this and leave figuring out the convergence for some other time.
That's because they were marked as I've changed that to only mark the 3D case as slow, since the 2D case is running pretty well locally. I imagine it will be a bit slower on the CI, since it needs to generate quite a few loopy/sumpy kernels, but nothing too bad. |
LGTM, thanks! Filed #45 so that we don't lose track that there's still something buried here. |
Has the following additions
HsiaoKressExteriorStokesOperator
that looks similar to the ones insymbolic.pde.scalar
. This was previously scattered intest_stokes
.test_scalar_int_eq
.