Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: disable high memory test case #223

Closed
wants to merge 3 commits into from

Conversation

alexfikl
Copy link
Collaborator

@alexfikl alexfikl commented Sep 9, 2023

This is running with the pymbolic@attrs branch to see if there's any test case we can disable to get that running on the Github CI (seems to have memory issues). Ran

mprof run python -m pytest -v -s -m 'not slowtest' --memray --most-allocations=25 test

on koelsch to see which cases use the most memory. There's a bunch of tests at around 2GB a piece, so going through them to see if it works :(

TODO:

  • Revert the pymbolic branch change in requirements.txt.

@alexfikl alexfikl marked this pull request as draft September 9, 2023 16:39
@alexfikl alexfikl force-pushed the slash-tests branch 4 times, most recently from 842968a to 8105e27 Compare September 9, 2023 19:58
@alexfikl
Copy link
Collaborator Author

alexfikl commented Sep 9, 2023

Hm, well this isn't great. I disabled the top 6 (this far) biggest memory tests (according to pytest-memray) and it's still failing..

@inducer
Copy link
Owner

inducer commented Sep 9, 2023

Thanks for digging! A kind of desperate, but maybe effective way might be to bisect by file...?

@alexfikl alexfikl force-pushed the slash-tests branch 2 times, most recently from 6f68bca to 918197b Compare September 11, 2023 13:35
@inducer
Copy link
Owner

inducer commented Dec 8, 2023

Huh, not pyvkfft's fault, or at least not entirely. 🤔 At least that matches the (questionable?) findings from #59 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants