Mypy #369
Merged
Mypy #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
inducer
commented
Nov 29, 2024
•
inducer
commented
- Needs Modernize 2024 meshmode#443
inducer
force-pushed
the
mypy
branch
2 times, most recently
from
c32fa0a to
b2a4672
Compare
Also - Drop SingleGridWorkBalancingPytatoArrayContext - Eliminate mixin-style MPIPytatoArrayContextBase
inducer
commented
Dec 2, 2024
| # is not available in meshmode's main branch | ||
| # (it currently needs | ||
| # https://github.com/kaushikcfd/meshmode/tree/pytato-array-context-transforms) | ||
| from meshmode.array_context import SingleGridWorkBalancingPytatoArrayContext |
There was a problem hiding this comment.
@matthiasdiener This is no longer relevant, right?
There was a problem hiding this comment.
I think so, yes. We have not been using the SingleGridWorkBalancingPytatoArrayContext for quite a while.
|
FYI @a-alveyblanc, mypy'd grudge is now a thing! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.