Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Formate la valeur affichée dans le champ NumberInput #659

Merged
merged 8 commits into from
Sep 2, 2024
Merged

Conversation

bjlaa
Copy link
Contributor

@bjlaa bjlaa commented Jul 31, 2024

No description provided.

@bjlaa bjlaa self-assigned this Jul 31, 2024
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nosgestesclimat ✅ Ready (Inspect) Visit Preview Sep 2, 2024 8:58am

Copy link

Copy link

github-actions bot commented Jul 31, 2024

Report for the pull request #659


🌐 Translation status

UI's texts

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

FAQ's questions

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

You will find more information about the translation in the dedicated file.

@@ -51,6 +51,7 @@ export const marianne = localFont({
export default async function RootLayout({ children }: PropsWithChildren) {
const lang = currentLocale()
const region = await getGeolocation()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary diff

function unformatNumber(number: string) {
// Supprimer les séparateurs de milliers
return Number(number.replace(/[^0-9.-]+/g, ''))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be static (e.g. helper or out of the component) to not re create function on each render

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes !

@bjlaa bjlaa merged commit bd708d5 into preprod Sep 2, 2024
7 checks passed
@bjlaa bjlaa deleted the NGC-998 branch September 2, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants