fix: use correct context for dial #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logic of the standard library is used here: https://github.com/golang/go/blob/go1.22.2/src/net/http/transport.go#L1485 If you think there is a problem, you can submit a PR to the upstream standard library |
|
Standard library does the right thing. Merge is done wrong. See the difference: |
|
Oh yeah, sorry I misunderstood before, this is a nice catch! |
|
Is it possible to cut a new release for the fix? |
|
Released in v3.43.2 @ferhatelmas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's lock protected and not safe for concurrent use.
It should use previously read context.
Otherwise, can panic under high concurrency.