Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pypi upload #213

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Fix pypi upload #213

merged 4 commits into from
Dec 20, 2024

Conversation

jncots
Copy link
Collaborator

@jncots jncots commented Dec 20, 2024

This is a small branch to fix problem with uploading of wheels on PyPI.

@jncots jncots requested a review from afedynitch December 20, 2024 05:18
Copy link
Member

@afedynitch afedynitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jncots
Copy link
Collaborator Author

jncots commented Dec 20, 2024

The problem was with new version of actions/upload-artifact@v4 that cannot change existing artifact. Each job in the matrix should have its own named artifact now. To download all artifacts to dist directory, we should omit "name" option in actions/download-artifact. To download all artifacts to the dist and not subfolders as

dist/
  artifact-1/
  artifact-2/
  .... 

we use merge-multiple: true .

@jncots jncots closed this Dec 20, 2024
@jncots jncots reopened this Dec 20, 2024
@jncots jncots merged commit d54ee6e into main Dec 20, 2024
7 of 8 checks passed
@jncots jncots deleted the fix_pypi_upload branch December 20, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants