fix: rename of valueName

impaktfull · Dec 12, 2023 · c9b1597 · c9b1597
1 parent 5d7a8b4
commit c9b1597
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# 0.10.2
+
+# Fix:
+- Renamed `valultName` to `opValueName` on `startBuildWithCertificateAndPasswordFromOnePassword` on the `CiCdPlugin`
+
 # 0.10.1
 
 # Fix:

diff --git a/example/bin/ic_op_cicdflow_ios_1password.dart b/example/bin/ic_op_cicdflow_ios_1password.dart
@@ -5,7 +5,7 @@ import 'example_config.dart';
 Future<void> main(List<String> arguments) => ImpaktfullCli().run(
       (cli) =>
           cli.ciCdPlugin.startBuildWithCertificateAndPasswordFromOnePassword(
-        vaultName: ExampleConfig.onePasswordVaultName,
+        opVaultName: ExampleConfig.onePasswordVaultName,
         opUuid: ExampleConfig.onePasswordUuid,
         keyChainName: ExampleConfig.keyChainName,
         globalKeyChainPassword: ExampleConfig.globalKeyChainPassword,

diff --git a/lib/src/integrations/ci_cd/plugin/ci_cd_plugin.dart b/lib/src/integrations/ci_cd/plugin/ci_cd_plugin.dart
@@ -158,8 +158,8 @@ class CiCdPlugin extends ImpaktfullPlugin {
 
   Future<void> startBuildWithCertificateAndPasswordFromOnePassword({
     required String opUuid,
+    required String opVaultName,
     required String keyChainName,
-    required String vaultName,
     required Future<void> Function() onStartBuild,
     Secret? rawServiceAccount,
     Secret? globalKeyChainPassword,
@@ -172,7 +172,7 @@ class CiCdPlugin extends ImpaktfullPlugin {
       rawServiceAccount: rawServiceAccount,
     );
     final certPassword = await onePasswordPlugin.getCertificatePassword(
-      vaultName: vaultName,
+      vaultName: opVaultName,
       opUuid: opUuid,
       rawServiceAccount: rawServiceAccount,
     );