chore: esm imports! #121
Merged
chore: esm imports! #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
commented
Oct 21, 2024
src/services/oauth.service.ts
Outdated
|
|
||
| const licenses = await this.database.getSponsorLicenses(profile.login); | ||
| const licenses = await this.database.getSponsorLicenses(profile.sub); |
There was a problem hiding this comment.
I have no idea if profile.sub is the right one lol
There was a problem hiding this comment.
Sub is likely the user id, but we want user login (afaik)
There was a problem hiding this comment.
I did something I should've done long ago.... I just RTFM. It's fixed now
danieldietzler
force-pushed
the
chore/esm-imports
branch
2 times, most recently
from
1432183 to
4c4ecd6
Compare
danieldietzler
force-pushed
the
chore/esm-imports
branch
2 times, most recently
from
7bf3616 to
1de3521
Compare
danieldietzler
force-pushed
the
chore/esm-imports
branch
from
1de3521 to
5fc2cc2
Compare
jrasm91
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #120