Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build libjxl v0.11.0 #125

Merged
merged 4 commits into from
Oct 8, 2024
Merged

feat: build libjxl v0.11.0 #125

merged 4 commits into from
Oct 8, 2024

Conversation

Starbix
Copy link
Contributor

@Starbix Starbix commented Oct 7, 2024

The build options are modeled after the Debian build files. One might need to force using the system LCMS2 as well.

@martabal
Copy link
Member

martabal commented Oct 7, 2024

You only installed the dev dependencies, you probably want to install the runtime dependencies https://packages.debian.org/experimental/libjxl0.10

I don't know if it's worth building libjxl ourselves. JPEG XL it's not that popular and that version would only help for hdr images (+ we have to wait for libvips to release a new version with the PR merged). It would be way easier to just wait for debian to update their libjxl version (but that could take a while)

cc @mertalev

@mertalev
Copy link
Contributor

mertalev commented Oct 7, 2024

I think we should build it. Waiting for Debian on this would take way too long.

server/bin/build-libjxl.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this locally with my latest changes, checked ldd /usr/local/libvips.so and tested it with JPEG and JPEG XL images in Immich. Everything looks good.

@mertalev mertalev merged commit 406c2c6 into immich-app:main Oct 8, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants