Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No side effects for profile navigation #153

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

boswelja
Copy link
Collaborator

@boswelja boswelja commented Sep 23, 2024

Summary of changes:

  1. Moved authentication handling directly into ViewModel
  2. Explicitly deserialize deep link args
  3. Don't manually update viewer ID

Tested changes:

Logs me in just fine

@boswelja boswelja added the enhancement Enhancement label Sep 23, 2024
@boswelja boswelja self-assigned this Sep 23, 2024
# Conflicts:
#	app/src/main/java/com/imashnake/animite/features/MainActivity.kt
#	gradle/libs.versions.toml
@imashnake0 imashnake0 merged commit 79f9ca3 into main Nov 13, 2024
1 check passed
@boswelja boswelja deleted the no-side-effects-on-login branch November 13, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants