Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NavigationSuiteScaffold #140

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

boswelja
Copy link
Collaborator

@boswelja boswelja commented Jul 14, 2024

Current issues:

  • "flicker" when changing top-level destinations
  • search icon doesn't shift when nav bar disappears
  • Nav bar state doesn't update until predictive back is committed Fixed

Summary of changes:

  1. NavigationSuiteScaffold

Tested changes:

Nav bar works

Currently missing animations
@boswelja boswelja self-assigned this Jul 14, 2024
# Conflicts:
#	app/src/main/java/com/imashnake/animite/features/home/HomeScreen.kt
#	app/src/main/java/com/imashnake/animite/features/searchbar/SearchFrontDrop.kt
#	navigation/src/main/kotlin/com/imashnake/animite/navigation/NavigationBar.kt
#	navigation/src/main/kotlin/com/imashnake/animite/navigation/NavigationScaffold.kt
@boswelja boswelja marked this pull request as ready for review November 24, 2024 06:14
@boswelja boswelja marked this pull request as draft December 4, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant