Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create from array #538

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Create from array #538

wants to merge 11 commits into from

Conversation

Xanthorapedia
Copy link

This PR creates ops that wrap 1-D or 2-D primitive arrays around ArrayImg or PlanarImg of RealTypes. The ops have been tested with random data to ensure the values and order of the values are as expected. A call to the ops takes the input array (1-D for ArrayImg and 2-D for PlanarImg with each 1-D element representing a plane) and the dimension of the image. If the image pixels are of variable length type, an additional parameter is required to specify the number of bits occupied by each point.

The PR is ready for code review.

@imagejan
Copy link
Member

The diff shows a lot of noise (i.e. deletions and additions of the same stuff), mostly introduced by 85ed7b4.

Can you rebase the branch on master and force push to clean up the history?

@awalter17
Copy link
Contributor

@Xanthorapedia Thank you for your work on these changes!

If you could please clean up the git history for this PR, that would be greatly appreciated. As @imagejan noted, there are a couple of commits with a lot of noise. Additionally, there appears to be duplicate commits (i.e. 99652b4 and 65868d9, etc.) and a merge commit which shouldn't be there. Cleaning up the history would make these changes much easier to review, and would help bring the PR closer to a "merge-able" state.

Also please check to make sure each commit builds with passing tests.

@ctrueden ctrueden added the to do label Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants