Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to
2949036
(#554)Needs image-rs/fdeflate#43
I like the previous solution with
warnings: Vec<Error>
, since it's easy to implement, uniformly handles all ancillary chunks, keepsInfo
small, and is lossless.Here's an alternative solution that keeps one parse error per chunk.
In either case, I think it's better to keep the errors than to discard them. It seems weird to have all these parsers and error enums that just get discarded. That's dead code.