Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitflags to v2 #400

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Bump bitflags to v2 #400

merged 1 commit into from
Dec 20, 2024

Conversation

daxpedda
Copy link
Contributor

Changelog: https://github.com/bitflags/bitflags/blob/2.0.0/CHANGELOG.md#200.

This is a breaking change. The API that is implemented for Transformations by the macro is now different.

@fintelia
Copy link
Contributor

Thanks for this PR. Since it is a breaking change, it'll have to wait for the next major release.

@fintelia fintelia closed this May 28, 2023
@fintelia fintelia reopened this May 28, 2023
@sjackman
Copy link

sjackman commented Oct 2, 2023

Since it is a breaking change, it'll have to wait for the next major release.

Any plans for a version 0.18.0 that includes this change? Thank you for your work on this useful crate!

@fintelia
Copy link
Contributor

Uh, not any immediate plans. There's a number of API changes I'd like to make at the same time, but it'll probably be a while before I have a chance to fully design what those should be

@nyurik
Copy link

nyurik commented Jan 27, 2024

@fintelia thx for your work on this. Is there a reason why you want to bundle all breaking changes together? Version numbers are "cheap" - it's ok to have several breaking versions as they become ready for release -- in my opinion, rapid iteration is better than stalled dependencies... Or am I missing something? Thx!

@fintelia
Copy link
Contributor

fintelia commented Jan 27, 2024

No, we do tend to be overly hesitant to do breaking changes.

Part of it is not getting a ton of user feedback beyond things like download counts which show some users being very slow to update (we still get a significant number of downloads for the 0.16.x series?!). There's also complications around whether to backport fixes or evaluating whether API design changes are actually improvements. But another big aspect is limited maintainer bandwidth that makes it easy to focus on issues/changes that can be handled immediately and let PRs with breaking changes drift to the end of the TODO list

@fintelia fintelia changed the base branch from master to next February 11, 2024 20:49
@anforowicz
Copy link
Contributor

Any updates? :-)

(One other breaking change that I'd like to see merged is #421 - maybe it's time to pull the trigger on both of them? I haven't looked closely at other PRs that may be waiting for their turn because they introduce breaking changes - e.g. I don't have a strong opinion whether #488 is ready or not.)

gnomesysadmins pushed a commit to GNOME/librsvg that referenced this pull request Aug 8, 2024
…e requires

Per image-rs/image-png#400, updating the png
crate for the new bitflags would cause a breaking change.  Looks like
the maintainers want to wait.

Part-of: <https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/1003>
@atouchet atouchet mentioned this pull request Nov 9, 2024
@hydra
Copy link

hydra commented Dec 16, 2024

Over a year has passed now, any chance of a release with this or #516 merged?

@fintelia fintelia merged commit 00e541b into image-rs:next Dec 20, 2024
@nyurik
Copy link

nyurik commented Dec 20, 2024

thanks!!!

fintelia pushed a commit to fintelia/image-png that referenced this pull request Dec 20, 2024
fintelia added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants