Merge branch 'main' into production-pilot

pytato/stringifier.py

@@ -95,7 +95,9 @@ def _map_generic_array(self, expr: Array, depth: int) -> str:
         if depth > self.truncation_depth:
             return self.truncation_string
 
-        fields = tuple(field.name for field in attrs.fields(type(expr)))
+        # type-ignore-reason: https://github.com/python/mypy/issues/16254
+        fields = tuple(field.name
+                       for field in attrs.fields(type(expr)))  # type: ignore[misc]
 
         if expr.ndim <= 1:
             # prettify: if ndim <=1 'expr.axes' would be trivial,
@@ -153,7 +155,8 @@ def _get_field_val(field: str) -> str:
 
         return (f"{type(expr).__name__}("
                 + ", ".join(f"{field.name}={_get_field_val(field.name)}"
-                            for field in attrs.fields(type(expr)))
+                    # type-ignore-reason: https://github.com/python/mypy/issues/16254
+                        for field in attrs.fields(type(expr)))  # type: ignore[misc]
                 + ")")
 
     def map_loopy_call(self, expr: LoopyCall, depth: int) -> str:

pytato/visualization/dot.py

@@ -184,7 +184,8 @@ def handle_unsupported_array(self,  # type: ignore[override]
         # Default handler, does its best to guess how to handle fields.
         info = self.get_common_dot_info(expr)
 
-        for field in attrs.fields(type(expr)):
+        # type-ignore-reason: https://github.com/python/mypy/issues/16254
+        for field in attrs.fields(type(expr)):  # type: ignore[misc]
             if field.name in info.fields:
                 continue
             attr = getattr(expr, field.name)

test/test_pytato.py

@@ -126,7 +126,6 @@ def test_stack_input_validation():
         pt.stack((x, x), axis=3)
 
 
-@pytest.mark.xfail  # Unnamed placeholders should be used via pt.bind
 def test_make_placeholder_noname():
     x = pt.make_placeholder("x", shape=(10, 4), dtype=float)
     y = 2*x