Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for devcontainers #73

Closed
wants to merge 2 commits into from
Closed

Conversation

wallento
Copy link

Devcontainers make it very easy for project to distribute the working development environment to their developers using VSCode.

This adds support for devcontainer, including the Github action.

The workflow is as following:

  • With every new version of the container, go to the GitHub actions, pick the "Build and publish devcontainer", and trigger the workflow action with the new version as parameter

  • Add the version to the devcontainer template, so that users can pick it, also update the version of template so it gets published (just increment the patch version), then trigger the workflow "Release devcontainer template"

Devcontainers make it very easy for project to distribute the working
development environment to their developers using VSCode.

This adds support for devcontainer, including the Github action.

The workflow is as following:

- With every new version of the container, go to the GitHub actions,
pick the "Build and publish devcontainer", and trigger the workflow
action with the new version as parameter

- Add the version to the devcontainer template, so that users can pick
it, also update the version of template so it gets published (just
increment the patch version), then trigger the workflow "Release
devcontainer template"
@wallento
Copy link
Author

Not sure if you want this. It also does not need to reside in this repo, but can be easily maintained outside.

You can just try it out by replacing iic-jku with wallento in the devcontainer template URL.

Add to an existing project: https://youtu.be/Mqqgis5QrbU

If this devcontainer is found in a project repo, this is the workflow: https://youtu.be/SGQzJ-WOaGI

As a bonus, it comes with Surfer support already via its VSCode plugin ,)

@wallento
Copy link
Author

Also, to note this is just quickly spinning it up and using a bit in my own projects, its not fully tested and further need might be needed.

The extra image is needed because devcontainer requires the user to exist, while there seems to be a necessity to have nss_wrapper. Maybe its an option to already have the user in passwd? But I assume it has a very good reason why you handle it that way.

@hpretl
Copy link
Member

hpretl commented Oct 28, 2024

@MrHighVoltage This looks like a good thing to add. Can you please take a look if anything else needs to be modified, or whether we can merge the changes as-is?

@hpretl hpretl requested review from MrHighVoltage and hpretl and removed request for hpretl October 28, 2024 05:08
@hpretl hpretl self-assigned this Oct 28, 2024
@hpretl hpretl added enhancement New feature or request next release labels Oct 28, 2024
@hpretl
Copy link
Member

hpretl commented Oct 29, 2024

Merged this PR into next_release, and will thus be part of that. Thanks for the contribution!

@hpretl hpretl closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants