Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split sample_bipartite() into two functions for the G(n,m) an… #1627

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Dec 10, 2024

…d G(n,p) case

Fix #630

Copy link
Contributor

aviator-app bot commented Dec 10, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

R/games.R Outdated Show resolved Hide resolved
@maelle maelle requested a review from szhorvat December 10, 2024 14:07
expect_equal(ecount(g5), 8)
expect_true(bipartite_mapping(g5)$res)
expect_true(is_directed(g5))
expect_output(print_all(g5), "5->11 7->11 8->11 8->12 4->13 5->13 6->13 9->13")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was updated as the seed is now set in a different position.

expect_equal(ecount(g6), 8)
expect_true(bipartite_mapping(g6)$res)
expect_true(is_directed(g6))
expect_output(print_all(g6), "11-> 4 11-> 5 12-> 7 12-> 8 12-> 9 14-> 6 14->10 15-> 4")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was updated as the seed is now set in a different position.

@maelle
Copy link
Contributor Author

maelle commented Dec 10, 2024

Locally, an unrelated test (at least, I was assuming it was unrelated 😅 ) is failing.

…d G(n,p) case

docs: fix manual page

docs: fix for pkgdown index

chore: also deprecate `bipartite()`

fix: fix deprecation message

docs: run `document()`

test: update snap

docs: fix manual page for `bipartite_gnp()`
test: fold `sample_bipartite()` tests into `test-games`

test: fold `test-hsbm` into `test-games`

test: fold `test-chung_lu` into `test-games`
@szhorvat
Copy link
Member

Do we want to autogen sample_bipartite_gnm / sample_bipartite_gnp?

@maelle
Copy link
Contributor Author

maelle commented Dec 17, 2024

Do we want to autogen sample_bipartite_gnm / sample_bipartite_gnp?

Let's discuss with @krlmlr. I am not skilled at autogen yet. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split sample_bipartite() into two functions for the G(n,m) and G(n,p) case
2 participants