Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin): better error msg #4446

Merged
merged 4 commits into from
Dec 16, 2024
Merged

chore(plugin): better error msg #4446

merged 4 commits into from
Dec 16, 2024

Conversation

julienrbrt
Copy link
Member

Closes: #4407

@julienrbrt julienrbrt added skip-changelog Don't check changelog for new entries backport/v28.x.y Backport to v28.x.y labels Dec 15, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd labels Dec 15, 2024
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
Copy link
Member

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Pantani
Pantani previously approved these changes Dec 16, 2024
Co-authored-by: Danny <[email protected]>
ignite/cmd/plugin.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) December 16, 2024 06:16
@julienrbrt julienrbrt disabled auto-merge December 16, 2024 12:49
@julienrbrt julienrbrt merged commit 709d52c into main Dec 16, 2024
43 of 45 checks passed
@julienrbrt julienrbrt deleted the julien/better-errmsg branch December 16, 2024 12:49
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
* chore(plugin): better error msg

* lint

* Update plugin.go

Co-authored-by: Danny <[email protected]>

* Update plugin.go

---------

Co-authored-by: Danny <[email protected]>
(cherry picked from commit 709d52c)
julienrbrt added a commit that referenced this pull request Dec 16, 2024
* chore(plugin): better error msg

* lint

* Update plugin.go

Co-authored-by: Danny <[email protected]>

* Update plugin.go

---------

Co-authored-by: Danny <[email protected]>
(cherry picked from commit 709d52c)

Co-authored-by: Julien Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIX: App Installation Error Msg
3 participants