-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workshop #5
base: master
Are you sure you want to change the base?
Workshop #5
Conversation
Matplotlib_common/plot_profs.py
Outdated
@@ -19,7 +19,8 @@ def plot_profiles(var_list, plot_iter, nplotx, nploty, axarr, xscaledict, yscale | |||
print file_name | |||
# try: | |||
profiles_file = open(file_name, "r") | |||
my_pos = read_my_var(profiles_file, "position") | |||
## my_pos = read_my_var(profiles_file, "position") | |||
my_pos = read_my_var(profiles_file, "time") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When plotting profiles, my_pos is altitude, not time.
If you want to change from position to time in plot_series, please change from position to altitude in plot_profs.
That may require additional changes in matplotlib code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still to be done
…into Workshop merge
This reverts commit ed62eef.
drawbicyc/drawbicyc.cpp
Outdated
@@ -19,7 +19,7 @@ int main(int argc, char** argv) | |||
("qv_qc_2_6_10_min", po::value<bool>()->default_value(false) , "plot comparison of qv and qc fields at 2, 6 and 10 min?") | |||
("dir", po::value<std::string>()->required() , "directory containing out_lgrngn") | |||
("micro", po::value<std::string>()->required(), "one of: blk_1m, blk_2m, lgrngn") | |||
("type", po::value<std::string>()->required(), "one of: dycoms, moist_thermal, rico, Lasher_Trapp")//, base_prflux_vs_clhght") | |||
("type", po::value<std::string>()->required(), "one of: dycoms, moist_thermal, rico, Lasher_Trapp, ICMW2020")//, base_prflux_vs_clhght") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change ICMW2020 to ICMW2020_cc to distinguish that this is the cumulus congestus case
@@ -308,10 +308,10 @@ class PlotterMicro_t : public Plotter_t<NDims> | |||
* 1e3; // to mm | |||
} | |||
// accumulated volume precipitation [m^3] | |||
double calc_acc_volume_precip(double prec_vol) | |||
double calc_acc_surf_precip__volume(double prec_vol) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why double underscore before volume?
{ | ||
if(this->micro == "lgrngn") | ||
return prec_vol / this->DomainVolume; | ||
return prec_vol / this->DomainSurf * calc_acc_surf_precip(prec_vol); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be:
return calc_acc_surf_precip(prec_vol) * this->DomainSurf / 1000.
regardless of the microphysics used (lgrngn or blk_1m)
snap *= plotter.CellVol; | ||
res_prof(at) = blitz::sum(snap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be more efficient to sum all elements first and then multiply the result by cellvol instead of multiplying all elements by the same value and summing afterwards.
Also, currently this only counts cloud droplets. You need to add rain_rw_mom0
No description provided.