Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/17 #18

Closed
wants to merge 12 commits into from
Closed

Features/17 #18

wants to merge 12 commits into from

Conversation

dortegau
Copy link
Member

@dortegau dortegau commented Jun 1, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Benefits

Better documentation adding the possibility to create a GitHub page using that static pages.

Possible Drawbacks

It's necessary to regenerate the documentation every time a comment is modified. Not sure if a webhook is enough to have consistent documentation.

Applicable Issues

#17

same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright 2018 Idealista, S.A.U. 😉

@dortegau
Copy link
Member Author

dortegau commented Jul 6, 2021

superseded by #21

@dortegau dortegau closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants