#36 Fix segmentation fault

CHANGELOG.md

@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a changelog](https://github.com/olivierlacan/keep-a-changelog).
 
 ## [Unreleased](https://github.com/idealista/yatm/tree/develop)
+## [2.1.2](https://github.com/idealista/yatm/tree/2.1.2)
+### Fixed
+- [#36](https://github.com/idealista/yatm/issues/36) *Fix another segmentation fault* @jmonterrubio
 ## [2.1.1](https://github.com/idealista/yatm/tree/2.1.1)
 ### Fixed
 - [#36](https://github.com/idealista/yatm/issues/36) *Fix segmentation fault* @jmonterrubio

molecule/default/converge.yml

@@ -10,7 +10,7 @@
         pkg: "{{ item }}"
         state: present
       with_items:
-        - libturbojpeg0-dev
+        - libjpeg62-turbo-dev
         - libtiff-dev
         - libgsf-1-dev
         - liblcms2-dev

molecule/default/group_vars/yatm/main.yml

@@ -2,8 +2,7 @@
 
 nodejs_version: 14.17.0
 
-vips_version: 8.11.2
-# vips_force_reinstall: true
+vips_version: 8.10.0
 
 yatm_install_path: /opt/yatm
 
@@ -28,7 +27,7 @@ yatm_build_libraries:
     - /usr/lib/x86_64-linux-gnu/libSM
     - /usr/lib/x86_64-linux-gnu/libICE
     - /usr/lib/x86_64-linux-gnu/libpng
-    - /usr/lib/x86_64-linux-gnu/libturbojpeg
+    - /usr/lib/x86_64-linux-gnu/libjpeg
     - /usr/lib/x86_64-linux-gnu/libtiff
     - /usr/lib/x86_64-linux-gnu/libgsf-1
     - /usr/lib/x86_64-linux-gnu/liblcms2

package.json

@@ -2,7 +2,7 @@
     "name": "yatm",
     "description": "Yet Another Thumbnail Manager. A libvips wrapper for Node.js",
     "author": "idealista <[email protected]> (http://www.idealista.com/labs/blog/)",
-    "version": "2.1.1",
+    "version": "2.1.2",
     "homepage": "https://github.com/idealista/yatm",
     "private": false,
     "dependencies": {

src/image.cc

@@ -86,7 +86,7 @@ namespace image {
 
     Image* Init(void *buffer, size_t const length) {
         Image *thumb = NULL;
-        VipsImage *out = vips_image_new_from_buffer(buffer, length, "", "access", VIPS_ACCESS_RANDOM, NULL);
+        VipsImage *out = vips_image_new_from_buffer(buffer, length, NULL, "access", VIPS_ACCESS_RANDOM, NULL);
         if (out != NULL) {
             thumb = new Image;
             thumb->img = out;

test/unit/resize.js

@@ -1,8 +1,12 @@
 'use strict';
 
+var fs = require('fs');
 var thumb = require('../../index');
 
 var image1 = 'test/unit/images/1.png';
+var buffer1 = fs.readFileSync(image1);
+var image2 = 'test/unit/images/1.jpg';
+var buffer2 = fs.readFileSync(image2);
 
 module.exports = {
     setUp : function(callback) {
@@ -26,6 +30,39 @@ module.exports = {
             }
         );
     },
+    testResizeBasicBuffer: function(assert) {
+        thumb(buffer1)
+        .resize(this.options.width,this.options.height)
+        .toBuffer(
+            function (err, data) {
+                assert.ok(!err, 'unexpected error: ' + err);
+                assert.notEqual(data, undefined);
+                assert.done();
+            }
+        );
+    },
+    testResizeBasicJpg: function(assert) {
+        thumb(image2)
+        .resize(this.options.width,this.options.height)
+        .toBuffer(
+            function (err, data) {
+                assert.ok(!err, 'unexpected error: ' + err);
+                assert.notEqual(data, undefined);
+                assert.done();
+            }
+        );
+    },
+    testResizeBasicBufferJpg: function(assert) {
+        thumb(buffer2)
+        .resize(this.options.width,this.options.height)
+        .toBuffer(
+            function (err, data) {
+                assert.ok(!err, 'unexpected error: ' + err);
+                assert.notEqual(data, undefined);
+                assert.done();
+            }
+        );
+    },
     testResizeNoHeight: function(assert) {
         assert.throws(function(){
             thumb(image1)