-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom font API #109
base: master
Are you sure you want to change the base?
Custom font API #109
Conversation
Awesome work! |
Thanks! |
Sweet! Thank you so much. FontFace can either get Canvas instance as well |
Hi @iddan. I'm sorry cause I have a lot of work on my job and finally I finished pull request. Could you check and note what I should fix? |
Also I have made new realization of toArg method. Could you check it? |
Looks good. But it doesn't use the |
As I understand logic of FontFaceSet usage in css, initialized class FontFaceSet saves in document.fonts property. And I save this property in this.fontFaceSet for more comfortable usage. |
Sorry, I was not clear enough. I meant you should represent the fonts interface on the React Native Side with a class of |
I guess I understand what you've said) |
Yes |
@jvink but this PR isn't finished yet |
@jvink this week or next i'll finish this PR. |
Hi! Any updates? |
Hey @Tanatcu any update? Very interested in this feature. Wondering what bug you found on iOS and if you were able to fix. |
Hey Guys, I need to use custom fonts @Tanatcu @tebatalla @hvlong do you have any updates or workarounds? |
Guys, if you need a workaround to render custom fonts you can just add |
@LautaroNavarro Good point. Actually it's the same job as font loader does. But thank you for pinging, I'm going to refresh my memory and look, how this long-life PR could be finally finished. |
I made a workaround like that here after importing fonts for both android and ios, you can use them in canvas.
|
@tolunaykan how did you import your fonts? I went the |
@tolunaykan could you explain what you did? I tried adding my font to my <style>
@font-face { font-family: 'Work Sans'; font-weight: 500; src: local('WorkSans-Medium'), url('WorkSans-Medium.ttf') format('truetype'); }
...
</style> ...but it didn't work. @laurenwilliams did you figure out how to get this working? |
Hi @Tanatcu ! Would love this feature, any chance you're going to work on this PR more? |
@lexi-stein Tbh I would like to continue working on this PR but have quite big problems with free time. I will try to look to it but can't promise anything. |
Added simple custom font loader for using custom fonts inside canvas WebView