Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leftpad section codes #1078

Merged
merged 2 commits into from
Dec 22, 2024
Merged

fix: leftpad section codes #1078

merged 2 commits into from
Dec 22, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Dec 22, 2024

Summary

  1. Courses with section codes less than 5 digits long are stored in AntAlmanac as is (5001 -> 5001). The API provides them as 5 digit leftpad strings. This was resulting in us not correctly loading in courses (most critically, BIO SCI).
Screenshot_2024-12-21_at_8 07 13_PM

Above: Saved AA Data
Below: API response

Test Plan

  1. Add and save courses from the 0 - 9,999 section code range
  2. Loading the courses in should work as expected
  3. Add and save courses from the 10,000 - 99,999 range.
  4. Loading the courses should be as expected
  5. Doing both together should work as expected

Issues

Closes Bug Report

@github-actions github-actions bot requested a deployment to staging-frontend December 22, 2024 04:22 In progress
Copy link
Member

@ecxyzzy ecxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ship boat emoji etc

@ecxyzzy ecxyzzy merged commit 9c4c17a into main Dec 22, 2024
1 of 3 checks passed
@ecxyzzy ecxyzzy deleted the kwu/leftpad-section-codes branch December 22, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants