lmsensors: Add lib/ to explicit search path to .so loader #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is missing any description and context. Please provide more information. |
gcongiu
requested changes
Sep 14, 2023
| @@ -399,6 +399,12 @@ link_lmsensors_libraries () | |||
| dl1 = dlopen(path_name, RTLD_NOW | RTLD_GLOBAL); // Try to open that path. | |||
| } | |||
|
|
|||
| // Step 4: Try another explicit install default. | |||
| if (dl1 == NULL && lmsensors_root != NULL) { // if root given, try it. | |||
| snprintf(path_name, 1024, "%s/lib/libsensors.so", lmsensors_root); // PAPI Root check. | |||
There was a problem hiding this comment.
Please use PATH_MAX instead of a raw value for string length
There was a problem hiding this comment.
Shall I update the num literal in the previous statements as well (line 398)?
There was a problem hiding this comment.
You can update it in a separate commit or even a new PR
There was a problem hiding this comment.
Updated as requested with PATH_MAX, and added commit to update the same for previous statement.
anustuvicl
force-pushed
the
2023.09.05-lmsensors_fix_lib_so_load
branch
from
81f335c to
5756dea
Compare
gcongiu
approved these changes
Sep 18, 2023
anustuvicl
force-pushed
the
2023.09.05-lmsensors_fix_lib_so_load
branch
from
5756dea to
03c4bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaviour observed on ICL Leconte
Shows the output
The problem happens because the component searches for
libsensors.soin$PAPI_LMSENSORS_ROOT/lib64while the so exists in$PAPI_LMSENSORS_ROOT/libThis PR fixes this problem by adding
libto the search path for the so file.After this fix the output of
papi_component_availshows