Updating papi_events.csv to support addition of L1I_CACHE in libpfm4 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of L1I_CACHE_ACCESS in libpfm4. Testing took place on a Neoverse V2 by comparing output from the commit prior to the addition of L1I_CACHE and the commit that adds L1I_CACHE. - Output for papi_avail was identical - Output for papi_command_line for the events PAPI_L1_ICA, PAPI_L1_ICH, PAPI_L1_TCA, and PAPI_L1_TCH was roughly identical.
Treece-Burgess
force-pushed
the
12.18.24-papi-events
branch
from
1ee08f0 to
091f106
Compare
Treece-Burgess
added
status-ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR replaces the event
L1I_CACHE_ACCESSinpapi_events.csvwith the eventL1I_CACHEfor Neoverse N1, N2, N3, V1, and V2. For more information on the addition ofL1I_CACHEsee PR #295.Testing took place only on a Neoverse V2 as the PAPI team currently does not have access to a Neoverse N1, N2, N3 or V1.
For testing, the presets events used were
PAPI_L1_ICA,PAPI_L1_ICH,PAPI_L1_TCA, andPAPI_L1_TCHas they are directly affected by this change.Output for
papi_availOutput for
papi_availon Neoverse V2 prior to the commit that adds theL1I_CACHEevent:Output for
papi_availon Neoverse V2 with the commit that adds theL1I_CACHEevent:The output is identical.
Output for
papi_command_lineOutput for
papi_command_lineon Neoverse V2 prior to the commit that adds theL1I_CACHEevent:Output for
papi_command_lineon Neoverse V2 with the commit that adds theL1I_CACHEevent:The output for the four events looks roughly identical.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests