Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump glutin from 0.27.0 to 0.29.0 #695

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 30, 2022

Bumps glutin from 0.27.0 to 0.29.0.

Release notes

Sourced from glutin's releases.

Glutin Version v0.29.0

  • Fix crash when creating OpenGLES context without explicit version.
  • Add buffer_age method on WindowedContext.
  • Return an Err instead of panicking when surfaceless GLX context creation fails on Linux.
  • Fix compilation on Android:
    • Switch from StaticStructGenerator to StructGenerator to dynamically load symbols.
    • Replace android_glue dependency with raw-window-handle, and remove broken lifecycle event handling.
    • Glutin can now be used on Android, however, the application must ensure it only creates the Context following a winit Event::Resumed event, and destroys the Context in response to a Event::Suspended event.
  • Updated winit dependency to 0.27.0. See winit's CHANGELOG for more info.
  • On Windows, build_raw_context now uses isize for hwnd to follow winit change.

Glutin Version v0.28.0

  • On Windows, fixed a panic for headless contexts because of active drag-and-drop (OleInitialize failed! Result was: RPC_E_CHANGED_MODE)
  • Updated winit dependency to 0.26.0. See winit's CHANGELOG for more info.
Changelog

Sourced from glutin's changelog.

Version 0.29.0 (2022-07-30)

  • Fix crash when creating OpenGLES context without explicit version.
  • Add buffer_age method on WindowedContext.
  • Return an Err instead of panicking when surfaceless GLX context creation fails on Linux.
  • Fix compilation on Android:
    • Switch from StaticStructGenerator to StructGenerator to dynamically load symbols.
    • Replace android_glue dependency with raw-window-handle, and remove broken lifecycle event handling.
    • Glutin can now be used on Android, however, the application must ensure it only creates the Context following a winit Event::Resumed event, and destroys the Context in response to a Event::Suspended event.
  • Updated winit dependency to 0.27.0. See winit's CHANGELOG for more info.
  • On Windows, build_raw_context now uses isize for hwnd to follow winit change.

Version 0.28.0 (2021-12-02)

  • On Windows, fixed a panic for headless contexts because of active drag-and-drop (OleInitialize failed! Result was: RPC_E_CHANGED_MODE)
  • Updated winit dependency to 0.26.0. See winit's CHANGELOG for more info.
  • Remove emscripten support leftover.
Commits
  • 9cf99a2 Glutin version v0.29.0
  • 4ff400e Set rust-version to 1.57
  • 689feb3 Switch from lazy_static to once_cell
  • 2bffbf5 Update winit dependency to v0.27.0
  • 3f80e54 ci: test for Android on arm and aarch64 architectures
  • a60a186 docs: clarifying that examples use gl_generator
  • c07dc56 Replace deprecated Error::cause() implementation with Error::source()
  • bd01f37 Fix clippy issues on macOS/ios
  • 2113c04 Fix cargo-apk link in README
  • f5aab1c Replace hardcoded html links with intradoc-links
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [glutin](https://github.com/rust-windowing/glutin) from 0.27.0 to 0.29.0.
- [Release notes](https://github.com/rust-windowing/glutin/releases)
- [Changelog](https://github.com/rust-windowing/glutin/blob/master/CHANGELOG.md)
- [Commits](rust-windowing/glutin@v0.27.0...v0.29.0)

---
updated-dependencies:
- dependency-name: glutin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 30, 2022
@iceiix
Copy link
Owner

iceiix commented Jul 30, 2022

Fails error[E0308]: mismatched types, needs simultaneous update of winit:

Updated winit dependency to 0.26.

@iceiix
Copy link
Owner

iceiix commented Jul 30, 2022

Updating to winit 0.26 fails:

the package stevenarella depends on winit, with features: web-sys but winit does not have these features.

emscripten support was removed, but we're not using emscripten for #446 (for better or worse).

https://github.com/rust-windowing/winit/releases/tag/v0.26.0
https://github.com/rust-windowing/winit/releases/tag/v0.27.0

also fails with winit 0.27. https://github.com/rust-windowing/winit/releases/tag/v0.26.0 says:

Breaking: On Web, remove the stdweb backend.

but we're using (or trying to use web-sys), not stdweb. https://github.com/rust-windowing/winit/blob/c53a574bff147ac35ac69c81bc48007094642108/README.md syas:

Winit supports compiling to the wasm32-unknown-unknown target with web-sys.

but our Cargo.toml tries to use it for all targets

@iceiix
Copy link
Owner

iceiix commented Jul 30, 2022

Removing features = web-sys fixes compilation, including on wasm. Presumably specifying the features is no longer needed/possible since stdweb, the alternate web backend, was dropped. Next failure is:

662 | window.set_cursor_grab(true).unwrap();
| ^^^^ expected enum CursorGrabMode, found bool

from https://github.com/rust-windowing/winit/releases/tag/v0.27.0

Breaking: Window::set_cursor_grab now accepts CursorGrabMode to control grabbing behavior.

example at: https://github.com/rust-windowing/winit/blob/master/examples/cursor_grab.rs

iceiix added a commit that referenced this pull request Jul 30, 2022
@iceiix iceiix closed this in ba3cf43 Jul 30, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 30, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/glutin-0.29.0 branch July 30, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant