Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

45 numpy vs np #46

Closed
wants to merge 2 commits into from
Closed

45 numpy vs np #46

wants to merge 2 commits into from

Conversation

shallmann
Copy link
Contributor

@shallmann shallmann commented Jun 18, 2022

this branch replaces all occurences of numpy by np ... checked that there are no accidential import np and import numpy occurences are all import numpy as np.

One script, the toise.fictive.py I found a bit strange, since there were some numpy functions used that had not been imported if I am not mistaken? Or was that intended and I was just not aware of if? Can someone verify that a np. was indeed missing in front of the linspace etc in that script? ...

@shallmann shallmann linked an issue Jun 18, 2022 that may be closed by this pull request
@shallmann
Copy link
Contributor Author

not sure why the linter tries to reformat stuff now... did not change any of these...

jvansanten added a commit that referenced this pull request Sep 25, 2024
jvansanten added a commit that referenced this pull request Sep 25, 2024
* sort imports

* remove unused imports

* cleaup up * imports

* numpy -> np

see #46

* blacken

* ci: macos to 14 (M1)
@jvansanten
Copy link
Collaborator

Finally implemented in #58 🙈

@jvansanten jvansanten closed this Sep 25, 2024
@jvansanten jvansanten deleted the 45-numpy-vs-np branch September 25, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy vs np
2 participants