GSF CubicInterpolation oscillation fix. #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pascalgutjahr noticed that in very rare cases, the GSF flux returns a close-to-zero negative value. It turned out this was due to the interpolation between the provided datapoints of the GSF model with scipy's
CubicSpline
.As sugested here we switched to scipy's
PchipInterpolator
, which is monotone between the interpolated points and prevents the oscillations. It is still cubic.The exact flux values changed a bit, so I had to recreate the test-values for GSF.
I added a test for this bug.