Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icetop effective area fix 2try #22

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Icetop effective area fix 2try #22

merged 4 commits into from
Oct 31, 2023

Conversation

matthiasplum
Copy link
Contributor

Okay the second try of getting the effective area fixed. The solution is to use the NaturalRateCylinder injector with a side length of zero.

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/simweights/_icetop_weighter.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@matthiasplum matthiasplum self-assigned this Oct 30, 2023
kathrawlins
kathrawlins approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@kathrawlins kathrawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kjmeagher kjmeagher merged commit 9ab1331 into main Oct 31, 2023
8 checks passed
@kjmeagher kjmeagher deleted the icetop_fix_2try branch October 31, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathrawlins kathrawlins kathrawlins approved these changes

@kjmeagher kjmeagher kjmeagher approved these changes

Assignees

@matthiasplum matthiasplum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiasplum @kjmeagher @kathrawlins