Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally fix map.plot, to be actually usable.. #787

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

LeanderFischer
Copy link
Collaborator

Added some extra parameters to the map plotting function, which now allow:

  1. using the raw bin names (from the binning config file) as title for each pid bin, by setting pure_bin_names=True
  2. using 'layout': 'tight' or 'layout': 'constrained' in fig_kw, to produce reasonable saved figures

The second point did not work before, because the colorbar was plotted 3 times for every pid bin, and not all of them were correctly moved by the layout option.. now it is keeping track of the main axis and only plotting the colorbar once. Results are rather nice now, as you can see here:

labeled_s_to_sqrt_b_0 3_GeV_combined_U_tau4_sq_0 0100_total

Copy link
Contributor

@anilak41 anilak41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

pisa/core/binning.py Outdated Show resolved Hide resolved
pisa/core/map.py Outdated Show resolved Hide resolved
pisa/core/map.py Outdated Show resolved Hide resolved
pisa/core/map.py Outdated Show resolved Hide resolved
pisa/core/map.py Outdated Show resolved Hide resolved
pisa/core/map.py Outdated Show resolved Hide resolved
@LeanderFischer LeanderFischer merged commit 1c0c173 into icecube:master Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants