-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finally fix map.plot, to be actually usable.. #787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilak41
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
thehrh
reviewed
Jul 31, 2024
thehrh
reviewed
Jul 31, 2024
thehrh
reviewed
Jul 31, 2024
thehrh
reviewed
Jul 31, 2024
thehrh
reviewed
Jul 31, 2024
thehrh
reviewed
Jul 31, 2024
Revert unit label style.
thehrh
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some extra parameters to the map plotting function, which now allow:
pure_bin_names=True
'layout': 'tight'
or'layout': 'constrained'
infig_kw
, to produce reasonable saved figuresThe second point did not work before, because the colorbar was plotted 3 times for every pid bin, and not all of them were correctly moved by the layout option.. now it is keeping track of the main axis and only plotting the colorbar once. Results are rather nice now, as you can see here: