Ignore partially-supported knots in spacing bounds #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is perfectly legitimate for the first and last `order` knots to be identical. Exclude these from the minimum and maximum knot spacing calculation to prevent elements of rmin_sep from becoming infinite.
jvansanten
force-pushed
the
shared-knot-fixup
branch
from
d19e6e3 to
72de218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression after #41 for splines where the first or last
orderknots are identical. These are perfectly valid, but ledrmin_septo become infinite, andsearchcenters()to get stuck in an infinite loop.