Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of TARGETARCH and TARGETPLATFORM for better multiarch builds #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dsbaars
Copy link

@dsbaars dsbaars commented Jun 10, 2022

I noticed a build arg was used to define the architecture, while there are TARGETARCH and TARGETPLATFORM variables available.

Now you can build multiarch docker images with the same tag, e.g.:
docker buildx build --platform=linux/arm64,linux/amd64 --build-arg version=dev --file Dockerfile.bullseye . --tag dsbaars/lightning-shell:latest --output "type=registry"

@AaronDewes
Copy link
Contributor

That's a thing in Docker? I never knew that, that makes a lot of stuff so much easier for me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants