Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved testing infrastructure #455

Merged
merged 39 commits into from
Dec 2, 2023
Merged

Improved testing infrastructure #455

merged 39 commits into from
Dec 2, 2023

Conversation

ianfhunter
Copy link
Owner

@ianfhunter ianfhunter commented Dec 2, 2023 •
edited
Loading

Description

  • Adding test to check for case brought up (disable because it does indeed segffault)
  • make the Python target install the local pip package for testing rather than doing weird path hacks and direct make calls
  • remove the one test that was testing the package
  • fix some build variables that were hard coded

Fixes #457

How Has This Been Tested

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Test Coverage (Additional test(s) without any extra code)
  • Documentation Improvements
  • Code Quality / Maintenance

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation & I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I give my permission for my code to be used in this project under this license and any future license terms

ianfhunter and others added 13 commits December 2, 2023 13:56
@ianfhunter
Create test_reported_bugs.py
f081cd3 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
1a155c1 
This commit fixes the style issues introduced in f081cd3 according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter
Merge branch 'main' into ianfhunter-patch-2
fff13c5
@ianfhunter
Update test_reported_bugs.py
fcc2caf 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
dd4c26b 
This commit fixes the style issues introduced in fcc2caf according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter
Update test_reported_bugs.py
6b33596 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update util.py
e6dae70 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
9839edb 
This commit fixes the style issues introduced in e6dae70 according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter
Update util.py
b9828e2 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update test_cli.py
5c098bd 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update __main__.py
8801d37 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update Makefile
0c01059 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update target.mk
bcea452 
Signed-off-by: Ian Hunter <[email protected]>
@github-actions github-actions bot added the Python label Dec 2, 2023
ianfhunter and others added 10 commits December 2, 2023 14:52
@ianfhunter
Update target.mk
5df302a 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update __main__.py
ebb3e83 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
d8fc9a6 
This commit fixes the style issues introduced in ebb3e83 according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter
Update __main__.py
6272fea 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update __main__.py
86bc395 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update __main__.py
b93a981 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
2bee7cd 
This commit fixes the style issues introduced in b93a981 according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter
Update __main__.py
afc4a17 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update test_reported_bugs.py
3392f0c 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
9f2b802 
This commit fixes the style issues introduced in 3392f0c according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter ianfhunter changed the title Addressing issues from #441 Improved testing infrastructure Dec 2, 2023
ianfhunter and others added 5 commits December 2, 2023 15:31
@ianfhunter
Update Makefile
8e496b6 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update Makefile
cb8e064 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update test_reported_bugs.py
dde2bd4 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
14869c3 
This commit fixes the style issues introduced in dde2bd4 according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter
Update Makefile
b4697fa 
Signed-off-by: Ian Hunter <[email protected]>
ianfhunter and others added 11 commits December 2, 2023 15:50
@ianfhunter
Update Makefile
b3dd5cc 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update Makefile
961e985 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update test_reported_bugs.py
cb5ea35 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
31c0199 
This commit fixes the style issues introduced in cb5ea35 according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@ianfhunter
Update Makefile
ca8fec1 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update test_core.yml
fd25607 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update Makefile
4505539 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update test_core.yml
85fdd46 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Delete tests/python/test_package.py
3d9dfb6 
Signed-off-by: Ian Hunter <[email protected]>
@ianfhunter
Update util.py
247476f 
Signed-off-by: Ian Hunter <[email protected]>
@deepsource-autofix
style: format code with Autopep8, Black, Go fmt, Gofumpt, isort and Yapf
42cf51b 
This commit fixes the style issues introduced in 247476f according to the output
from Autopep8, Black, Go fmt, Gofumpt, isort and Yapf.

Details: #455
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ianfhunter ianfhunter merged commit d61f400 into main Dec 2, 2023
37 checks passed
@ianfhunter ianfhunter deleted the ianfhunter-patch-2 branch December 2, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve workflow for "pip install ."
1 participant
@ianfhunter