Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the bounds sdk has on exporter-otlp, so v0.0.2 (containing bugfixes of the last two years) can actually be used #112

Closed
wants to merge 5 commits into from

Conversation

Qqwy
Copy link
Contributor

@Qqwy Qqwy commented Mar 13, 2024

When using the libraries by depending on in hs-opentelemetry-sdk, you'll end up with a very outdated version of hs-opentelemetry-exporter-otlp, as the current bound was still ==0.0.1.*. However version 0.0.2.0 contains many important bugfixes like for instance #42 and #89.

This PR loosens this bound.

@Qqwy Qqwy changed the title Loosen the bounds sdk has on exporter-otlp, so v0.0.2 (containing bugfixes of the last two years) actually are applied Loosen the bounds sdk has on exporter-otlp, so v0.0.2 (containing bugfixes of the last two years) can actually be used Mar 13, 2024
@Qqwy
Copy link
Contributor Author

Qqwy commented Mar 13, 2024

@iand675 What do you want me to do with the failing format spec? It is complaining about a lot (all?) files, none of which I touched as I obviously only touched the .yaml and .cabal file in ./sdk.

Maybe the version of fourmolu that is loaded inside the Github action was recently bumped?

EDIT: And I believe the run on GHC 8.12 is failing as a stack yaml for 8.10 exists but not for 8.12.

EDIT2: Ah, now I see #92 / #97

@Qqwy
Copy link
Contributor Author

Qqwy commented Mar 13, 2024

I also bumped the actual versions set in the package configs themselves as curiously some of them were behind their changelogs.

@michaelpj
Copy link
Collaborator

I think this is resolved with the new release.

@michaelpj michaelpj closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants