Merge pull request #13 from iamyukihiro/fix-test

test: Remove DTO test
iamyukihiro · Apr 29, 2024 · 5f98e52 · 5f98e52
2 parents b294866 + 48459ea
commit 5f98e52
Show file tree

Hide file tree

Showing 12 changed files with 28 additions and 153 deletions.
diff --git a/bin/dev/down b/bin/dev/down
@@ -1,3 +1,3 @@
 #!/bin/sh
-cd bin/dev/ || exit
+cd bin/dev/ &&
 docker compose down -v
diff --git a/src/Service/PsySH/AddMedakaCommand.php b/src/Service/PsySH/AddMedakaCommand.php
@@ -22,7 +22,7 @@ public function __construct(
     /**
      * {@inheritDoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('add-medaka')

diff --git a/src/Service/PsySH/InitTankCommand.php b/src/Service/PsySH/InitTankCommand.php
@@ -20,7 +20,7 @@ public function __construct(
     /**
      * {@inheritDoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('init-tank')

diff --git a/src/Service/PsySH/ViewTankCommand.php b/src/Service/PsySH/ViewTankCommand.php
@@ -20,7 +20,7 @@ public function __construct(
     /**
      * {@inheritDoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('view-tank')

diff --git a/tests/AquariumTest.php b/tests/AquariumTest.php
@@ -1,5 +1,7 @@
 <?php
 
+/** @noinspection NonAsciiCharacters */
+
 declare(strict_types=1);
 
 namespace Iamyukihiro\Aquarium;

diff --git a/tests/Domain/Model/Fish/MedakaTest.php b/tests/Domain/Model/Fish/MedakaTest.php
diff --git a/tests/Domain/Model/Tank/TankManager/LoadTankTest.php b/tests/Domain/Model/Tank/TankManager/LoadTankTest.php
diff --git a/...n/Model/Tank/TankManager/SaveTankTest.php → tests/Domain/Model/Tank/TankManagerTest.php b/...n/Model/Tank/TankManager/SaveTankTest.php → tests/Domain/Model/Tank/TankManagerTest.php
@@ -4,18 +4,16 @@
 
 declare(strict_types=1);
 
-namespace Iamyukihiro\Aquarium\Domain\Model\Tank\TankManager;
+namespace Iamyukihiro\Aquarium\Domain\Model\Tank;
 
 use Iamyukihiro\Aquarium\Domain\Exception\NotFileOpenException;
-use Iamyukihiro\Aquarium\Domain\Model\Tank\Tank;
-use Iamyukihiro\Aquarium\Domain\Model\Tank\TankManager;
 use PHPUnit\Framework\TestCase;
 
-class SaveTankTest extends TestCase
+class TankManagerTest extends TestCase
 {
     private string $path;
 
-    protected function setUp(): void
+    private function setUpReadableTank(): void
     {
         $this->path = dirname(__FILE__) . '/../../.memory/tank_test.memory';
 
@@ -31,8 +29,10 @@ protected function setUp(): void
         fclose($fileHandle);
     }
 
-    public function test_(): void
+    public function test_save(): void
     {
+        $this->setUpReadableTank();
+
         $tank = new Tank();
 
         $SUT = $this->getSUT($this->path);
@@ -47,8 +47,20 @@ public function test_(): void
         );
     }
 
+    public function test_load(): void
+    {
+        $this->setUpReadableTank();
+
+        $SUT = $this->getSUT($this->path);
+        $actual = $SUT->load();
+
+        $this->assertInstanceOf(Tank::class, $actual);
+    }
+
     public function test_Tankファイルが開けない場合は例外を返すこと(): void
     {
+        $this->setUpReadableTank();
+
         $this->expectException(NotFileOpenException::class);
         $tank = new Tank();
 

diff --git a/tests/Domain/Model/Tank/TankTest.php b/tests/Domain/Model/Tank/TankTest.php
diff --git a/tests/Domain/VO/VarietyTest.php b/tests/Domain/VO/VarietyTest.php
diff --git a/tests/Service/PsySH/AddMedakaCommandTest.php b/tests/Service/PsySH/AddMedakaCommandTest.php
@@ -1,5 +1,7 @@
 <?php
 
+/** @noinspection NonAsciiCharacters */
+
 declare(strict_types=1);
 
 namespace Iamyukihiro\Aquarium\Service\PsySH;

diff --git a/tests/Service/PsySH/ViewTankCommandTest.php b/tests/Service/PsySH/ViewTankCommandTest.php
@@ -1,5 +1,7 @@
 <?php
 
+/** @noinspection NonAsciiCharacters */
+
 declare(strict_types=1);
 
 namespace Iamyukihiro\Aquarium\Service\PsySH;